docs (#2194): fix issue with autofocus on custom directives page #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bencodezen
force-pushed
the
2194/fix-autofocus-issue-on-custom-directives
branch
from
5f10c1d
to
10fc360
Compare
bencodezen
added
bug
NataliaTepluhina
approved these changes
Sep 16, 2024
NataliaTepluhina
deleted the
2194/fix-autofocus-issue-on-custom-directives
branch
tisma95
added a commit
to tisma95/vue-en-docs
that referenced
this pull request
Sep 17, 2024
AloisSeckar
added a commit
to AloisSeckar/vuejs-docs
that referenced
this pull request
Sep 17, 2024
NataliaTepluhina
pushed a commit
that referenced
this pull request
Sep 26, 2024
NaokiHaba
added a commit
to NaokiHaba/docs-ja
that referenced
this pull request
Sep 29, 2024
jay-es
pushed a commit
to vuejs-translations/docs-ja
that referenced
this pull request
Sep 29, 2024
* docs: fix issue with autofocus on custom directives page * chore: update CSS for custom directives page * docs: remove unnecessary Japanese translation in custom directives page * Fix base on vuejs/docs#2994 * feat: Add v-focus directive for input autofocus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The autofocus example in custom directive makes the guide appear to be buggy since it jumps down automatically on page load.
Proposed Solution
I've replaced the example with a more generic
vHighlightexample to demonstrate how it would work, but retained the practical lessons from the benefits ofvFocusin a new "When to use custom directives" so people can learn from it still.Open to other suggestions though if people have a better example that comes to mind!
Additional Information
Closes #2914