-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(no-empty-component-block): support auto fix #2595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
Co-authored-by: Yosuke Ota <[email protected]>
…ue into feat/add-auto-fix
Co-authored-by: Flo Edelmann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks @waynzh!
resolve #2564
Add support for automatically deleting empty blocks.
Chose this approach is because I couldn't find a better way to handle reporting & fixing eachemptyBlock
within a for loop, as removing the first block will affect the range of the second block😵💫.UPDATE: Due to lack of whitespaces in test cases.