Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): generate codes for :key prop on v-for and v-if node #4544

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

so1ve
Copy link
Member

@so1ve so1ve commented Jul 8, 2024

I created a fake component to generate codes since IF_BRANCH nodes are not valid elements. Not sure if it is the best approach.

fixes #4539

@so1ve so1ve changed the title fix(language-core): generate codes for :key prop on <template v-if> node fix(language-core): generate codes for :key prop on f-for and v-if node Jul 8, 2024
@so1ve so1ve changed the title fix(language-core): generate codes for :key prop on f-for and v-if node fix(language-core): generate codes for :key prop on v-for and v-if node Jul 8, 2024
@so1ve so1ve marked this pull request as draft July 9, 2024 09:15
@so1ve so1ve marked this pull request as ready for review July 9, 2024 09:44
@johnsoncodehk
Copy link
Member

I temporarily changed the issue to a draft because we should wait for vuejs/core#11322 to be fixed by the upstream. Forcibly handling unrecognized props in language tools will make the code we need to maintain too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

props on template are not checked
2 participants