Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): JSDoc display support when typing props on component template #4796

Merged
merged 9 commits into from
Sep 4, 2024

Conversation

joy-yu
Copy link
Contributor

@joy-yu joy-yu commented Sep 3, 2024

resolve #4663

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4796

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4796

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4796

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4796

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4796

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4796

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4796

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4796

commit: aa603f6

@joy-yu
Copy link
Contributor Author

joy-yu commented Sep 3, 2024

@ferferga PR is here. But I don't know how to write a test script to test it, It may need the help of more experienced developers.

@johnsoncodehk
Copy link
Member

Great work, thanks!

@johnsoncodehk johnsoncodehk merged commit 5c7e153 into vuejs:master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can it show comment information when typing props?
3 participants