Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinia v3 #2905

Closed
wants to merge 19 commits into from
Closed

Pinia v3 #2905

wants to merge 19 commits into from

Conversation

posva
Copy link
Member

@posva posva commented Feb 1, 2025

  • Remove Vue 2 support
    • Remove vue-demi
    • Remove workarounds for Vue 2
    • Remove Nuxt bridge (Nuxt 2) support
  • Remove deprecated APIs
    • No more defineStore({ id: 'id' })
    • No PiniaStorePlugin (use PiniaPlugin)
  • Upgrade @vue/devtools-api to v7
  • Remove older TS support (anything >=5 should be good)

TODO:

  • Write migration guide v2 to v3
  • Update docs to not mention Vue 2
  • Create a deployment for v2 docs
    • Use local search only
  • Migrate to type: module in package.json

It would be great to also ensure the Nuxt plugin works well even with layers so we can release a v1 instead of staying in 0.x when the nuxt module has been stable for a long time 😆

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 6feffcd
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/67ab0a6168b5c3000891057e

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.23%. Comparing base (394f655) to head (6feffcd).
Report is 4 commits behind head on v2.

Files with missing lines Patch % Lines
packages/pinia/src/createPinia.ts 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2905      +/-   ##
==========================================
+ Coverage   88.46%   91.23%   +2.77%     
==========================================
  Files          19       17       -2     
  Lines        1456     1381      -75     
  Branches      227      211      -16     
==========================================
- Hits         1288     1260      -28     
+ Misses        167      120      -47     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 6feffcd
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67ab0a61d9842c00083a190e

Copy link

pkg-pr-new bot commented Feb 1, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2905
npm i https://pkg.pr.new/pinia@2905
npm i https://pkg.pr.new/@pinia/testing@2905

commit: e3b5f6d

@posva
Copy link
Member Author

posva commented Feb 11, 2025

v3 is now the default branch

@posva posva closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants