fix($shared-utils): improve title inference and header extraction for…

… markdown links syntax
vuejs · Dec 19, 2020 · d264e50 · d264e50
1 parent cd4ad04
commit d264e50
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/packages/@vuepress/shared-utils/__tests__/parseHeaders.spec.ts b/packages/@vuepress/shared-utils/__tests__/parseHeaders.spec.ts
@@ -19,6 +19,10 @@ describe('parseHeaders', () => {
       '\\*vue\\*': '*vue*',
       '\\!vue\\!': '!vue!',
 
+      // #2688
+      '[vue](vuejs.org) / [vue](vuejs.org)': 'vue / vue',
+      '[\\<ins>](vuejs.org)': '<ins>',
+
       // #564 For multiple markdown tokens
       '`a` and `b`': 'a and b',
       '***bold and italic***': 'bold and italic',

diff --git a/packages/@vuepress/shared-utils/__tests__/removeNonCodeWrappedHTML.spec.ts b/packages/@vuepress/shared-utils/__tests__/removeNonCodeWrappedHTML.spec.ts
@@ -44,7 +44,10 @@ test('removeNonCodeWrappedHTML', () => {
     '# H1 `<Comp></Comp>` H2': '# H1 `<Comp></Comp>` H2',
     '# H1 `<Comp a="b"></Comp>` H2': '# H1 `<Comp a="b"></Comp>` H2',
     '# H1 `<Comp/>` H2': '# H1 `<Comp/>` H2',
-    '# H1 `<Comp a="b"/>` H2': '# H1 `<Comp a="b"/>` H2'
+    '# H1 `<Comp a="b"/>` H2': '# H1 `<Comp a="b"/>` H2',
+
+    // #2688
+    '# \\<ins>': '# \\<ins>'
   }
 
   Object.keys(asserts).forEach(input => {

diff --git a/packages/@vuepress/shared-utils/src/parseHeaders.ts b/packages/@vuepress/shared-utils/src/parseHeaders.ts
@@ -15,9 +15,9 @@ import parseEmojis from './parseEmojis'
 // wrapped by <code>(markdown token: '`') tag.
 
 const removeMarkdownTokens = (str: string): string => String(str)
-  .replace(/\[(.*)\]\(.*\)/, '$1')              // []()
-  .replace(/(`|\*{1,3}|_)(.*?[^\\])\1/g, '$2')  // `{t}` | *{t}* | **{t}** | ***{t}*** | _{t}_
-  .replace(/(\\)(\*|_|`|\!)/g, '$2')            // remove escape char '\'
+  .replace(/(\[(.[^\]]+)\]\((.[^)]+)\))/g, '$2')  // []()
+  .replace(/(`|\*{1,3}|_)(.*?[^\\])\1/g, '$2')    // `{t}` | *{t}* | **{t}** | ***{t}*** | _{t}_
+  .replace(/(\\)(\*|_|`|\!|<)/g, '$2')           // remove escape char '\'
 
 const trim = (str: string): string => str.trim()
 

diff --git a/packages/@vuepress/shared-utils/src/removeNonCodeWrappedHTML.ts b/packages/@vuepress/shared-utils/src/removeNonCodeWrappedHTML.ts
@@ -3,5 +3,5 @@
 // Input: "<a> b",   Output: "b"
 // Input: "`<a>` b", Output: "`<a>` b"
 export = function removeNonCodeWrappedHTML (str: string): string {
-  return String(str).replace(/(^|[^><`])<.*>([^><`]|$)/g, '$1$2')
+  return String(str).replace(/(^|[^><`\\])<.*>([^><`]|$)/g, '$1$2')
 }