fix(theme-default): samesite css #987
Conversation
|
Could you help to confirm if the fix valid when there is a search input? For example, enabling |
rottenpen
force-pushed
the
fix/theme-header
branch
from
16abac4
to
28daebb
Compare
|
its not good when there is a search input. and i fix it. @meteorlxy |
|
I saw you set the width to a fixed value. Have you tested with navbar items? |
what is navbar items ? multi navbar items? |
|
I think your fix is invalid. |
| @@ -15,10 +15,15 @@ | |||
| } | |||
|
|
|||
| .site-name { | |||
| display: inline-block; | |||
| width: calc(100vw - 18rem); | |||
There was a problem hiding this comment.
Obviously because of dynamic contents in navbar, we should never set this to a fixed value.
There was a problem hiding this comment.
oh，i see. Is it better to limit the navbar-items-wrapper and navbarBrand width with js?
conflict between the two when their too long
Description
Linked with this feature request issue vuepress/ecosystem#3
Note
mobile:
pc: