feat: Support multiple settings #1314
Draft
+142
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
commented
Feb 10, 2025
| @@ -3,7 +3,7 @@ | |||
| const spawn = require('cross-spawn'); | |||
|
|
|||
| const ariaAtRepo = 'https://github.com/w3c/aria-at.git'; | |||
| const ariaAtDefaultBranch = 'master'; | |||
| const ariaAtDefaultBranch = 'fix-1002-test'; // TODO: Revert to master before merging; based on test PR https://github.com/w3c/aria-at/pull/1126 | |||
There was a problem hiding this comment.
Warning
This branch was set to test an example scenario with the "Alert" plan and should be reverted before merging
There was a problem hiding this comment.
Warning
The settings introduced here are fake (included through w3c/aria-at#1126) and should be removed before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple settings, being introduced in w3c/aria-at#1125.
Note: Do not merge until w3c/aria-at#1125 is merged and my below inline comments are addressed (#1314 (comment) and #1314 (comment))