Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: GraphQL updates based on issue #406 #411

Closed
wants to merge 1 commit into from

Conversation

alflennik
Copy link
Contributor

This PR proposes GraphQL schema changes for issue #406. Some changes might not be obvious from reading the diff:

  • Giving TestResults their own table, instead of continuing to store them as JSON data in the TestPlanRun table. This will permit setting up Postgres associations between each TestResult and the AT and Browser versions.
  • Giving Tests a table as well, which will keep the Test model symmetrical with the TestResult model.
  • The FindOrCreateTestPlanReport mutation will no longer automatically create atVersions and browserVersions, since mutations are being added to explicitly manage these.

@alflennik alflennik requested a review from howard-e April 6, 2022 20:18
@@ -736,7 +711,8 @@ const graphqlSchema = gql`
"""
input TestPlanReportInput {
testPlanVersionId: ID!
testPlanTarget: TestPlanTargetInput!
atId: ID!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this so quickly! I know this is still marked as a draft but was wondering if this shouldn't include atVersion and browserVersion as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank YOU for looking at this so quickly 😁 So, splitting up the At / Browser and AtVersion / BrowserVersion is intentional - I put the atVersion and browserVersion fields on the TestResult type. This means that reports are locked to an AT and Browser, but they're no longer locked to an exact version. And now each TestResult can have slightly different versions. Let me know if you imagined something different maybe?

@alflennik alflennik mentioned this pull request Apr 26, 2022
@alflennik
Copy link
Contributor Author

Closed because Erika took this one over the finish line!

@alflennik alflennik closed this May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants