-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new modals based on #406 #415
Conversation
<Form.Label> | ||
Approximate date of availability | ||
</Form.Label> | ||
<Form.Control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This input should be masked to a date format (DD-MM-YYYY
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to this
{uaMajor === '0' && ( | ||
<Form.Group className="at-browser-details-full-column"> | ||
<Form.Label>Enter Browser Version</Form.Label> | ||
<Form.Control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version string input could be masked (x.y.z-additional.identifiers
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on all three modals and on updating the BasicModal
. The usage examples demonstrate clean APIs for these components. The AtAndBrowserDetailsModal
, especially, is clean, easy to read, and well implemented. Looking forward to seeing these components in the wild!
<Form.Label> | ||
Approximate date of availability | ||
</Form.Label> | ||
<Form.Control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to this
This adds 3 new modals based on #406.
AtAndBrowserDetailsModal
, along with logic to account for described scenarios.BasicThemedModal
, where a theme ('warning' or 'danger'), content and possible actions may be passed as props.UpdateVersionModal
.See usage examples below: