Update Test Reports, Test Queue and Test Run pages #419

howard-e · 2022-05-03T14:36:48Z

This implements sweeping changes across the Test Reports related pages, Test Queue and Test Run pages. It accounts for GraphQL server-based changes and numerous design related changes as dictated by #406.

Components which have been added/changed based on such includes:

Test Reports
- Version related identifiers have been removed
- Run History now shown per test
Test Queue - Admin View
- Manage Assistive Technology Versions
- Add Test Plans to the Test Queue
Managing Assistive Technology Versions Modals
- Scenario 1 - Adding a New AT Version Modal
- Scenario 2 - Edit an Existing AT Version Modal
- Scenario 3 - Removing an Existing AT Version - Danger Modal
- Scenario 4 - Adding an Existing AT Version
- Scenario 5 - Removing an AT Version already in use - Warning Modal

Known Issues

Flicker when saving result of AT and Browser Details modal
Test Reports client query not supported
Anonymous Test Run client query not supported
Confirmation dialogs with editing and creating actions with Manage Test Queue Component

alflennik

Looks good just a couple little comments

client/components/common/UpdateVersionModal/index.jsx

client/tests/__mocks__/GraphQLMocks.js

client/utils/formatter.js

…ersions)

…d ua-parser-js

…os when server-side functionality added

…r at version

…ersion and BrowserVersion

…ith remove-test-plan-target-migration

alflennik

I'll need to continue reviewing this, I feel like I only got through 10% of all the capabilities we've added and I know a few more are incoming too. Here are a couple of thoughts I did have which hopefully are helpful.

alflennik · 2022-05-26T20:24:49Z

client/components/common/UpdateVersionModal/index.jsx

                            onChange={handleDateAvailabilityTextChange}
+                            onKeyPress={handleDateAvailabilityTextKeyPress}
+                            maxLength={10}
                        />


I was able to sidestep the validation by pasting in some arbitrary text. This is admin-only so it may or may not be worth the effort to account for that.

Also you can hit submit at any time, even if the admin forgot to type in a date (in which case there is an internal error). This also may or may not be worth the effort to address. I do know keeping this component simple was a goal of the design.

@alflennik good points! I had initially overlooked such validation at the time with the plan to return to it and never did, so thanks for pointing that out.
I've now pushed commits which should include proper feedback to these situations. Please check again when you can

alflennik · 2022-05-26T20:45:54Z

client/components/common/AtAndBrowserDetailsModal/index.jsx

@@ -204,7 +249,7 @@ const AtAndBrowserDetailsModal = ({
                            </ModalSubtitleStyle>
                        </legend>
                        {/* Tester Scenario 1 */}


I'm leaning towards removing these "scenario x" labels because I think issue 406 won't be actively maintained going forward, but the code will be. So I predict there'll be future scenarios or alternate scenarios that will make the scenario numbers lose their usefulness. That said, Isaac does have some pretty extensive documentation for the feature so I could be swayed to change my opinion.

isaacdurazo

This is a test. Please ignore, Howard 😅

isaacdurazo

Another test.

…plans

evmiguel

@howard-e (great job!) and I walked through the code together. I tested the different scenarios as well. Changes from #423 have also been added to this PR.

alflennik approved these changes May 5, 2022

View reviewed changes

client/components/common/UpdateVersionModal/index.jsx Outdated Show resolved Hide resolved

client/tests/__mocks__/GraphQLMocks.js Show resolved Hide resolved

client/utils/formatter.js Outdated Show resolved Hide resolved

evmiguel mentioned this pull request May 24, 2022

Changes to TestPlanUpdaterModal in the absence of TestPlanTarget #423

Closed

howard-e force-pushed the new-manage-test-queue branch 2 times, most recently from 9c27ecf to c1f0018 Compare May 25, 2022 21:08

howard-e and others added 26 commits May 26, 2022 15:09

Added basic themed modal

406d281

Update BasicModal and add UpdateVersionModal (Add & Edit Browser/AT V…

59fc566

…ersions)

Change titles to h1s

3d125db

Adjusted styling for modals; Added At and Browser Details Modal; Adde…

23c03f8

…d ua-parser-js

Updated logic for AT and Browser Details modal

b372084

Prop updates for modals

55d8705

Add Manage Test Queue disclosure components

b8af9f5

Making Manage AT Versions functional

1e791a7

Update client-side functionality for Manage Test Queue component; tod…

8a02264

…os when server-side functionality added

Update tests for new manage test queue component

c815c3f

Update tests

26ee939

Update TestQueue to reference new AtVersion structure

c7dad1c

Now accounting for releasedAt attribute when adding/updating at versions

166fc00

Update tests

53944bd

Change date formatter to DD-MM-YYYY

bb52a68

Change how theme evaluated when trying to remove atVersion

8cbc697

Remove old test queue management components

5c5601d

Renaming parameters

767a6e1

Added server integration for create, edit and delete functionality fo…

9005ac7

…r at version

Rename ManageTestQueue component update function attribute name

8f42878

Address PR feedback

9013422

Comment currently unusued sections

417dc14

Handling removal of TestPlanTarget table and updating the data in AtV…

1aa6640

…ersion and BrowserVersion

Moving AT and Browser Version changes to seeder

cfd994c

TestPlanTarget migration and At/Browser seeder

b889884

Removed testPlanTarget dependency on TestQueue page following merge w…

a781644

…ith remove-test-plan-target-migration

evmiguel added 5 commits May 26, 2022 16:20

Removing inability to update report with no results

c310a08

Correcting the source for atVersionId and browserVersionId

23419c8

Updating client queries and TestResultInput

fdc07a6

Updating mock test data

46c9d1e

Addressing feedback

ee164f6

howard-e requested review from evmiguel and alflennik May 26, 2022 20:37

howard-e changed the title ~~Add New Manage Test Queue Component~~ Update Test Reports, Test Queue and Test Run pages May 26, 2022

alflennik reviewed May 26, 2022

View reviewed changes

isaacdurazo self-requested a review May 27, 2022 21:46

isaacdurazo reviewed May 27, 2022

View reviewed changes

isaacdurazo requested changes May 27, 2022

View reviewed changes

isaacdurazo approved these changes May 27, 2022

View reviewed changes

howard-e marked this pull request as ready for review May 31, 2022 14:51

howard-e added 10 commits May 31, 2022 13:27

Add warning modals when admin attempts to edit AT and Browser versions

81a4994

Improve error feedback messages and elements focus

619d47b

Fix AtAndBrowserDetails error when not admin

5b05196

Fix error feedback for TestRenderer

dc73965

Fix flicker on Test Run page

a852b56

Date availability text length check

d6f8208

Add feedback modal focus for add test plan to test queue button

54ca198

Add additional invalid ua checks

27e5581

Address sorts

bfac3c7

Update dependency array with UA variables

48f7025

howard-e force-pushed the new-manage-test-queue branch from a7a3907 to 48f7025 Compare May 31, 2022 18:30

Use all versions array instead of filtered when creating adding test …

ed4d355

…plans

evmiguel approved these changes May 31, 2022

View reviewed changes

Update implementation for arrow with disclosures

889d043

evmiguel merged commit 3ba26ed into main May 31, 2022

evmiguel deleted the new-manage-test-queue branch May 31, 2022 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Test Reports, Test Queue and Test Run pages #419

Update Test Reports, Test Queue and Test Run pages #419

howard-e commented May 3, 2022 •

edited

Loading

alflennik left a comment

alflennik left a comment

alflennik May 26, 2022

howard-e May 31, 2022

alflennik May 26, 2022

isaacdurazo left a comment

isaacdurazo left a comment

evmiguel left a comment

Update Test Reports, Test Queue and Test Run pages #419

Update Test Reports, Test Queue and Test Run pages #419

Conversation

howard-e commented May 3, 2022 • edited Loading

alflennik left a comment

Choose a reason for hiding this comment

alflennik left a comment

Choose a reason for hiding this comment

alflennik May 26, 2022

Choose a reason for hiding this comment

howard-e May 31, 2022

Choose a reason for hiding this comment

alflennik May 26, 2022

Choose a reason for hiding this comment

isaacdurazo left a comment

Choose a reason for hiding this comment

isaacdurazo left a comment

Choose a reason for hiding this comment

evmiguel left a comment

Choose a reason for hiding this comment

howard-e commented May 3, 2022 •

edited

Loading