Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Collection revision #439

Merged
merged 7 commits into from
Jul 5, 2022
Merged

Version Collection revision #439

merged 7 commits into from
Jul 5, 2022

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jun 23, 2022 •
edited
Loading

Implements version collection revisions submitted in #436.

@howard-e howard-e requested a review from evmiguel June 23, 2022 20:41
@howard-e howard-e force-pushed the version-collection-revision branch from 9b73357 to d68c1e5 Compare June 29, 2022 19:14
evmiguel
evmiguel approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@evmiguel evmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @howard-e! I ran through each scenario as well. Looks good.

@howard-e howard-e merged commit e6e92c9 into main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evmiguel evmiguel evmiguel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @evmiguel