Add hidden JSON metadata to issues created by the app #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
@alflennik looks good! I checked through to make sure everything worked as it did before and this definitely makes it a bit easier to update how the issues are queried by the App in the future!
client/components/CandidateReview/CandidateTestPlanRun/index.jsx
Outdated
Show resolved
Hide resolved
client/components/CandidateReview/CandidateTestPlanRun/index.jsx
Outdated
Show resolved
Hide resolved
|
@howard-e would you be willing to take another look? The big change since you last saw it is that I added an issues field to the test plan type to get a list of all issues ever raised for a test plan (including issues for reports that no longer exist). |
howard-e
requested changes
Sep 21, 2023
|
@howard-e all the feedback should be addressed now, thanks for the review! |
howard-e
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
@alflennik looks good to me! Thanks for addressing the feedback
21 tasks
howard-e
added a commit
that referenced
this pull request
Sep 28, 2023
…abase Implementation to support #648 (#688) Changes added to primarily support #648, but also #518 and w3c/aria-at#950. This includes functional changes to the Data Management, the Test Queue and the Candidate Review pages. It also includes changes to the database structure, described in #632. * feature: updates functionality of Data Management page (#713) * feature: updates functionality of Test Queue page (#715) * feature: updates functionality of Candidate Review page (#715) * feature: include functionality to support the concept of required reports (#722) * feature: adds Test Plan Report Status dialog (#728) * enhancement: move Candidate Phase Start Date and Target Completion Date into dedicated columns on Candidate Review page (#730) * feature: adds Test Plan Version page (#747) * enhancement: explicitly support ‘DEPRECATED’ phase status for TestPlanVersions (#749) * feature: adds filter and sorting functionality by columns headers on Data Management page (#750) * bugfix: update semantic structure of cells with multiple list items on Data Management page (#752) * enhancement: include GitHub issues on Test Plan Version page (#753) * bugfix: revision of the required reports conditions for updating to CANDIDATE and RECOMMENDED phases (#764) * bugfix: removes superfluous header from Test Plan Report Status dialog (#766) * bugfix: update and revise sorts, headings and descriptions of elements on Test Plan Version page (#767) * bugfix: account for several other update phase scenarios that could prevent the update from happening if there is an older TestPlanVersion that exists with results (#771) * bugfix: update headings and revise deprecated dates shown on Test Plan Version page (#773) * enhancement: allow updating of GitHub issues being presented in the app to be more easily understood (#775) * bugfix: correct deprecatedAt date to be relative to when the ‘next’ TestPlanVersion was added (#780) * enhancement: update the text shown when deprecation occurs during a phase on Test Plan Version page (#781) * bugfix: fix inverted sort descriptions and pin sort of of Test Plan name columns on Data Management page (#790) --------- Co-authored-by: Erika Miguel <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]> Co-authored-by: Stalgia Grigg <[email protected]> Co-authored-by: Howard Edwards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users raise issues through the app we insert a hidden comment into the issue which is used to later track the issue within the app. This PR improves the system by converting the hidden comment from a string, which was difficult to parse, to JSON, allowing us to remove most of the string parsing logic from the issue system. It also fixes a problem caused by the fact that most users who raise issues do not have the ability to attach the required issue labels - the system now relies on the hidden metadata and missing labels should no longer cause issues. Related to #768.