-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editorial: revise custom stylesheets #2410
base: main
Are you sure you want to change the base?
Conversation
Removes unused and commented-out styles as per #2226 (comment)
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
notes to self:
|
Removes unused and commented-out styles as per #2226 (comment)
- aria spec - rewrite content model figure to actual figure, using respec features - common.css: remove .image and . img-caption
It turns out, core-aam only sets styling that are already set in common.css. |
- remove core-aam.css - all styling is done identically in common.css - core-aam/index.html - removes link to core-aam.css
Stylesheet was removed as all styling is done identically in common.css
@jnurthen @spectranaut @daniel-montalvo I think I actually want to suggest to remove all of common.css. Almost all of it is minor stylistic differences to what respec does (i.e., everything after the table styles). For tables, I would suggest to switch to respec's The only other bit are the nested lists styles. However, only accname actually needs these (and I feel like respec or W3C TR styles should be doing a better job here - but they probably don't want to risk it but perhaps be open to opt-in classes). [For completeness: there are 2 nested lists in aria in 4.3.2 - all other nested lists in specs are from respec TOCs where the styles are set by respec.] I'll prep something for the next editors meeting so we can go through them together. |
Resolves #2226
table.def
from w3.org/StyleSheets/TR/2021/base.css (i.e., remove our custom styles and replace table classes with.def
)th{ background-color:#eee; }
(cf. Text-to-background contrast in tables under ARIA's Definition of Roles too low #2394 + duplicates)#example-48
=> https://github.com/speced/respec/wiki/ReSpec-Editor's-Guide#examplesPreview | Diff