[css21] floats-145 ; modified the test so that a

reference file could be more reliable. More info: https://lists.w3.org/Archives/Public/public-css-testsuite/2016Apr/0033.html and servo/servo#10458 (comment) Credits should go to Patrick Walton.
w3c · May 31, 2016 · 9ee3de7 · 9ee3de7
1 parent ed091c6
commit 9ee3de7
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 23 deletions.
diff --git a/css21/floats-clear/floats-145-ref.xht b/css21/floats-clear/floats-145-ref.xht
@@ -8,18 +8,20 @@
   <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" />
 
   <style type="text/css"><![CDATA[
-  div
-  {
-  border-bottom: green solid 1em;
-  display: inline;
-  }
+  img
+    {
+      margin-top: 90px;
+      vertical-align: top;
+    }
   ]]></style>
 
  </head>
 
  <body>
 
-  <div>Test passes if there is a green bar and <strong>no red</strong>.</div>
+  <p>Test passes if there is a blue bar.</p>
+
+  <div><img src="support/swatch-blue.png" width="330" height="30" alt="Image download support must be enabled" /></div>
 
  </body>
-</html>
+</html>
diff --git a/css21/floats-clear/floats-145.xht b/css21/floats-clear/floats-145.xht
@@ -3,27 +3,37 @@
  <head>
   <title>CSS Test: Bottom margins on floats</title>
   <link rel="author" title="Ian Hickson" href="mailto:[email protected]"/>
+  <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" />
   <link rel="alternate" href="http://www.hixie.ch/tests/adhoc/css/box/float/045.html" type="text/html"/>
+  <link rel="bookmark" href="https://github.com/servo/servo/pull/10458#issuecomment-210204244" />
+  <link rel="bookmark" href="http://lists.w3.org/Archives/Public/public-css-testsuite/2016Apr/0028.html" title="About floats-145" />
   <link rel="help" href="http://www.w3.org/TR/CSS21/visuren.html#floats" />
   <link rel="match" href="floats-145-ref.xht" />
 
-  <style type="text/css">
-   div {
-     float: left;
-     background: green;
-   }
-   span {
-     float: left;
-     background: white;
-     margin: 0 0 1em 0;
-   }
-  </style>
+  <style type="text/css"><![CDATA[
+  div
+    {
+      background-color: blue;
+      float: left;
+      font: 30px/3 Ahem; /* computes to 30px/90px */
+    }
+
+  span
+    {
+      background-color: white;
+      color: white;
+      float: left;
+      margin-bottom: 1em;
+    }
+  ]]></style>
+
  </head>
+
  <body>
-  <div>
-   <span>Test passes if there is a green bar and <strong>no red</strong>.</span>
-   <!-- (note: the "no red anywhere" clause is just for consistency with other tests, this test has no red. -->
-  </div>
+
+  <p>Test passes if there is a blue bar.</p>
+
+  <div><span>Text sample</span></div>
+
  </body>
 </html>
-