Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes markup in Sec.3.8 (Graph Comparison) #137

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fixes markup in Sec.3.8 (Graph Comparison) #137

merged 1 commit into from
Jan 17, 2025

Conversation

hartig
Copy link
Contributor

@hartig hartig commented Jan 17, 2025

In preparation for working on #128, this PR fixes the markup within Sec.3.8. In particular, <var> has been used incorrectly. For instance, M(lit)=lit is not a variable but a formula; the variables in this formula are M and lit.


Preview | Diff

@hartig hartig requested review from gkellogg and afs January 17, 2025 10:47
@pchampin
Copy link
Contributor

I'm happy with this as a preparation, acknowledging that it does not solve #128 yet.

I'm raising a flag, though: the mapping M is defined on nodes, and the current definition of nodes only includes the subjects and objects of the asserted statements, so recursing on triple-terms may not work...

@hartig
Copy link
Contributor Author

hartig commented Jan 17, 2025

@pchampin

I'm raising a flag, though: the mapping M is defined on nodes, and the current definition of nodes only includes the subjects and objects of the asserted statements, so recursing on triple-terms may not work...

Yes, I am aware of this issue. See my recent comment on #128, which includes a proposal to change the domain and codomain of M. This proposal also covers the issue that you point out here.

@hartig hartig merged commit 4d1cc8c into main Jan 17, 2025
3 checks passed
@hartig hartig deleted the Issue128pre branch January 17, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants