Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag all dfns as non-exported in release version of WebCrypto #1251

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Apr 7, 2023

See discussion in #1250

The definitions are extracted as "exported" because the release version of the spec does not follow the usual dfn data model, but this creates duplication issues in Bikeshed specs.

Valid references to the WebCrypto API do not use the xref mechanism in any case so marking the definitions as private should not have any consequences for existing specs.

See discussion in #1250

The definitions are extracted as "exported" because the release version of the
spec does not follow the usual dfn data model, but this creates duplication
issues in Bikeshed specs.

Valid references to the WebCrypto API do not use the xref mechanism in any case
so marking the definitions as private should not have any consequences for
existing specs.
@tidoust tidoust requested a review from dontcallmedom April 7, 2023 10:29
@tidoust tidoust merged commit 47d429d into main Apr 7, 2023
@tidoust tidoust deleted the patchdfns-webcrypto branch April 7, 2023 11:36
tidoust added a commit that referenced this pull request Apr 7, 2023
Bug fixed:
- Flag all dfns as non-exported in release version of WebCrypto (#1251)

Dependencies bumped:
- Bump web-specs from 2.54.0 to 2.55.0 (#1253)
- Bump puppeteer from 19.8.0 to 19.8.5 (#1248, #1252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants