-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify which style properties do not apply to ruby containers #1071
Clarify which style properties do not apply to ruby containers #1071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be simplified to remove repetition by factoring the spans into two classes with defined terms, one of which is "all spans" and the other is the spans excluding ruby container, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot accept this suggested alternative to #1069 as it violates editorial and design principles that have been consistently applied to the TTML specifications. Please suggest specific changes you wish to see in #1069. However, such changes should not include text to be added/changed in each individual property; rather, the correct place to document inapplicability constraints is in §10.2.35.1 as is presently done by #1069.
I see no evidence behind that statement. In fact, TTML today clearly specifies to which vocabulary each style property applies. |
@palemieux the general design/editorial principle in play here is: do not specify something (in normative text) which is a logical consequence of other normative statements; in the current case, you have proposed adding qualifying language (i.e., claiming non-applicability) for 18 style attributes; a close reading of each of these attributes' specifications show that 3 of them still need to apply to ruby container spans ( that leaves us with only one possibly case to consider,
now, since we have already specified that non-LWSP text is forbidden from ruby container spans and we will have added (in #1069) that LWSP is ignored for presentation processing, then there is no text (including white space, letter spacing, and word spacing), i.e., no glyph areas to which text decoration could be logically applied; in evaluating these details, it is quite clear that we do not have to specify that something does not apply to something that cannot be present or is explicitly ignored; consequently, the note added by #1069 to §10.2.35.1 suffices, by reminding the reader of this fact (and that does not need to be otherwise stated in normative text); notwithstanding the above, I believe there are a few improvements we could make in #1069, such as
|
@skynavga Your argument is disproved by the simple fact that character-based style attributes do not apply to |
@palemieux you keep mixing up applicability of styles to elements and applicability of styles to elements in a specific context; character styles can never apply to |
@skynavga According to CSS 2.1, applies to" indicates whether properties have no rendering effect on some types of elements. |
@palemieux I guess I need to say it for a 3rd, or is this the 4th time, a ruby container is not an element; a |
I've re-read @skynavga 's #1071 (comment) and agree that the text decorations are not supposed to create any marks other than on text content, and since there isn't any in a container span, we don't need to say anything. The screenshot at #1043 (comment) therefore looks like a browser bug. I haven't checked that similar wording applies to all the other style properties that seemingly should not cause any marks to be made if applied to a container span. @skynavga or @palemieux did you check that? |
@nigelmegitt yes, I checked the specification text for each of the 18 properties, as I stated in #1071 (comment), 3 of those actually should apply (bidi and wrap related), and the other 15 cannot apply because they semantically apply only to glyph areas |
@skynavga You are missing my point. I am arguing for specification clarity, and providing unambiguous guidance to implementers. According to your analysis, the applicability of style properties is not trivial. The applies to attribute of each style property definition provides a simple and straightforward means to communicating this applicability. If |
@palemieux |
…cation' into issue/1043-character-styles-do-not-apply-to-ruby-containers
…tion' into issue/1043-character-styles-do-not-apply-to-ruby-containers
…gy-application' into issue/1043-character-styles-do-not-apply-to-ruby-containers
…ion' into issue/1043-character-styles-do-not-apply-to-ruby-containers
…ion' into issue/1043-character-styles-do-not-apply-to-ruby-containers
@nigelmegitt and @cconcolato I have introduced the defined term "ruby container span" as suggested. |
spec/ttml2.xml
Outdated
@@ -12094,7 +12100,10 @@ if the computed value of <att>tts:ruby</att> of a <loc href="#content-vocabulary | |||
<item><p>the computed value of <att>tts:ruby</att> of each of its child elements is not <code>none</code>;</p></item> | |||
<item><p>the computed value of <att>tts:ruby</att> of its first child element is <code>baseContainer</code> | |||
or <code>base</code>;</p></item> | |||
<item><p>each of its text node children contain only <loc href="#style-value-lwsp"><lwsp></loc>;</p></item> | |||
<item><p>each of its text node children and <loc href="#terms-anonymous-span">anonymous span</loc> children |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other PR, I think the presentation processing behavior should not be mixed with the content model. I'd prefer having a separate paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the individual comment, it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a TTWG member, looks good to me.
As Chair, noting that we do not currently have consensus to merge this, I'm going to mark it as "Request Changes", but not because of any objection from me individually. If we can reach consensus for these changes then I'll change it to Approve.
Chair's block not needed because there's a member block already
…r-styles-do-not-apply-to-ruby-containers
Closes #1043
Closes #1078
Closes #1080
Closes #1082
Closes #1084
Closes #1086
Closes #1100