Adding ruby pinyin example (#251, #274). #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
reviewed
Jan 31, 2018
spec/ttml2.xml
Outdated
| <td> | ||
| <eg xml:space="preserve"> | ||
| <p> | ||
| <span tts:ruby="container" <phrase role="strong">tts:rubyAlign="center"</phrase>> |
There was a problem hiding this comment.
Why is the phrase role="strong" here in this example? I think it should be removed because it makes it look as though the use of pinyin is somehow dependent on the ruby alignment.
There was a problem hiding this comment.
Agree. Will remove it.
|
@nigelmegitt can you check again? |
nigelmegitt
reviewed
Feb 7, 2018
nigelmegitt
approved these changes
Feb 8, 2018
r12a
approved these changes
Feb 15, 2018
skynavga
approved these changes
Feb 15, 2018
skynavga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #274 and #251