Merge with upstream #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wasmparser: Get more GC spec tests passing Newly passing tests: * `br_on_cast.wast` * `br_on_cast_fail.wast` * `struct.wast` Newly implemented instructions: * `struct.new` * `struct.get` * `struct.get_s` * `struct.get_u` * `struct.set` * `br_on_cast` * `br_on_cast_fail` * wasmparser: Get all GC spec tests passing The `extern.wast` test was already passing. The `ref_eq.wast` test required implementing `ref.eq`, which is very simple. And now all of the GC spec tests are passing! * Review feedback
* Add parsing for `linking` custom section * Document symbol linking flags Upstream spec: https://github.com/WebAssembly/tool-conventions/blob/main/Linking.md * Move `WASM_SYM_*` constants to the linking section Which is more appropriate since they are defined upstream in `Linking.md` rather than `DynamicLinking.md`. * Add access to subsections in linking section API This provides a more obvious way to access subsections. It is easier to discover than the existing `IntoIterator` impl. * Clone the iterator instead of returning mutable reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.