Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom fonts to be accessed via tailwind class #291

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

vincanger
Copy link
Collaborator

Custom fonts were included but weren't being configured correctly. Now users have an example of how to include custom fonts and access them based on the name they provide in the tailwind.config.js file, e.g. <div className='font-satoshi>

@vincanger vincanger requested a review from Martinsos October 15, 2024 09:45

/* Here is an example of how to add a custom font.
* Fonts are stored in the public/fonts folder.
* They can then be used with tailwind as with the font-satoshi class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't quite get this part as with the font-satoshi class, I think I am missing some context, will they have it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I tried to make the comment a bit more explicit!

Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one tiny comment!

@vincanger vincanger merged commit 685e025 into main Oct 29, 2024
1 check passed
@vincanger vincanger deleted the fix-fonts branch October 29, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants