Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable docker-listener wodle #609

Open
wants to merge 1 commit into
base: 4.3
Choose a base branch
from
Open

Enable docker-listener wodle #609

wants to merge 1 commit into from

Conversation

kravietz
Copy link
Contributor

alberpilot
alberpilot previously approved these changes Nov 24, 2021
Copy link
Contributor

@alberpilot alberpilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myu1d157h0u54nd
Copy link
Contributor

Hello @kravietz
Thank you for using Wazuh and contributing to improve it. I will be taking this PR for testing and review.
In our master branch it corresponds to the development version. It is possible that I will move the destination of the merge to branch 4.2 to take it to the stable branch within the flow that we carry.

@alberpilot alberpilot changed the base branch from master to 4.3 November 24, 2021 16:05
@alberpilot alberpilot dismissed their stale review November 24, 2021 16:05

The base branch was changed.

@myu1d157h0u54nd
Copy link
Contributor

Hi @kravietz
After doing some tests, I see that it is necessary to add additional changes. Can you please add them to your PR so that the contribution record is kept by you?

They would be in: roles/wazuh/ansible-wazuh-agent/defaults/main.yml
within:

# wazuh_agent_config
wazuh_agent_config_defaults:

add:

  docker_listener:
    disable: 'yes'

and in: roles/wazuh/ansible-wazuh-agent/tasks/Linux.yml

- name: Linux | Ensure group "wazuh" exists
  group:
    name: wazuh
    state: present

@duviful
Copy link

duviful commented Apr 21, 2023

I am looking forward to seeing this functionality merge. I will handle the code.

@itprogression @alberpilot, Should I start a new PR? I don't know if GitHub lets me contribute to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants