forked from opensearch-project/OpenSearch-Dashboards
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate versioning to JSON format and update build scripts #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…Docker ignore files
efbc2ba
to
ade9553
Compare
…lder script" This reverts commit ade9553.
Tostti
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test
deb amd64
root@vagrant:/home/vagrant# cat /usr/share/wazuh-dashboard/VERSION.json
{
"version": "4.12.0",
"stage": "alpha1",
"commit": "49776f5-db2484a6d-ac5e4ed"
}
rpm x86_64
[root@vbox vagrant]# cat /usr/share/wazuh-dashboard/VERSION.json
{
"version": "4.12.0",
"stage": "alpha1",
"commit": "49776f5-db2484a6d-ac5e4ed"
}
CR 🟢
LGTM
yenienserrano
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the standardization process, all XDR-SIEM repositories will use a consistent identification method. Each repository will include a standardized
VERSION.json
file containing necessary data to identify the origin branch and release stage. This file should be included in the installer's installation directory and indicate the short commit used to create it.Requirements
GitHub
VERSION.json
file in the root directory.VERSION.json
.JSON
format (with required keys).version
key value must follow theMAJOR.MINOR.PATCH
format.stage
key value must indicate therelease stage
, using lowercase and no spaces.41200
) should be replaced by thestage
value from the version file.JSON
file.Installers
VERSION.json
file in the installation directory:/var/ossec
(or equivalent)/usr/share/wazuh-{dashboard/indexer}
version
andstage
(revision) should be fetched from theVERSION.json
file.VERSION.json
provided in the installer package should include theshort commit
used to create the it. If the repository requires a compound commit due to dependencies, use it instead of a short commit.440
Documentation
Resources
VERSION.json file content and structure
Issues Resolved
#526
Changelog
Check List
yarn test:jest
yarn test:jest_integration