-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 182: Add WebDriver BiDi support to testdriver.js #182
RFC 182: Add WebDriver BiDi support to testdriver.js #182
Conversation
c164c83
to
d5f8541
Compare
87c94ff
to
40ffc38
Compare
@jgraham @gsnedders friendly ping |
Given no feedback in 3 weeks this RFC has passed an I'll go ahead and merge it. Feedback on the implementation and experience writing tests with this will probably require some additional changes, but I trust we can figure that out. I'm quite excited to see BiDi used to improve WPT testing capabilities, and want to see the next phase of this. |
I'm not happy with the unilateral merge here. This was brought up at the last infra meeting and there was a commitment to give feedback. Although I appreciate the letter of the process allows this, I don't think such unilateral action is in the spirit of collaboration, even though I understand that there can be frustration when people's internal priorities are blocked on community feedback. I'm going to revert this change and we can discuss further. |
Reverted via #184 Unfortunately you'll need to create a new PR to continue this RFC. |
I was not in that meeting, so I didn't know about those commitments. Expedient review of #185 would be much appreciated. On the process, it has a timeout in the absence of feedback for a reason, and I would expect it to be used by others if Google doesn't provide any feedback too. |
I've filed #187 because the revert was outside of our documented process. |
@jgraham I'm sorry for the miscommunication happened on the meeting. I got the silence as "let's experiment with the proposed solution, and we can figure out details on the implementation stage". |
Add “testdriver.js” support for WebDriver BiDi events and actions.
Preview