Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish harness status from subtests in test results view #449

Closed
foolip opened this issue Aug 17, 2018 · 1 comment
Closed

Distinguish harness status from subtests in test results view #449

foolip opened this issue Aug 17, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@foolip
Copy link
Member

foolip commented Aug 17, 2018

https://wpt.fyi/results/quirks/classname-query-after-sibling-adoption.html?sha=c0a1bc68d7 looks like this:
image

https://wpt.fyi/results/visual-viewport/viewport-unscaled-scale-iframe.html?sha=c0a1bc68d7, with harness errors:
image

(The "File status" misnomer is #419 + #448, should be "Harness status" here.)

Harness statuses aren't passes and failures, but rather a failure to correctly run the test. While harness errors aren't always a serious problem, I believe we should treat them as a separate problem and drive them down close to zero across wpt: web-platform-tests/wpt#10877.

Harness statuses also shouldn't be part of summary numbers, see #62.

Taking this together, I believe we should present them as distinct from subtests. I suggest gray for "OK", and purple (as in #421 (comment)) for anything else. Mockups of the above examples:
image
image

@foolip
Copy link
Member Author

foolip commented Oct 18, 2019

Oh, but #449 might not be the issue that fixed the color the first time, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants