Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the first row in test-file-results display #595

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Separate the first row in test-file-results display #595

merged 2 commits into from
Oct 2, 2018

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Sep 27, 2018 •
edited
Loading

Description

More subtle fix for #449

@lukebjerring lukebjerring requested a review from foolip September 27, 2018 19:29
@lukebjerring lukebjerring changed the title Rowsplit Separate the first row in test-file-results display Sep 27, 2018
@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://rowsplit-dot-wptdashboard-staging.appspot.com

@foolip
Copy link
Member

foolip commented Oct 2, 2018

Looking at https://rowsplit-dot-wptdashboard-staging.appspot.com/results/ambient-light/AmbientLightSensor-disabled-by-feature-policy.https.html?label=stable&aligned=true, I can't tell the difference. Am I looking at the wrong thing?

@lukebjerring
Copy link
Contributor Author

Sorry, child PR didn't seem to work so well. Reset now that #594 is landed. PTAL.

@foolip
Copy link
Member

foolip commented Oct 2, 2018

Still can't see a difference, tried https://rowsplit-dot-wptdashboard-staging.appspot.com/results/dom/historical.html?label=stable&aligned=true this time. Do you have a URL that works for you?

@lukebjerring
Copy link
Contributor Author

There's an extra 8px of whitespace under the headers.

@foolip
Copy link
Member

foolip commented Oct 2, 2018

Can you share a screenshot of what you see? Seems like we must be getting different content server or something?

@lukebjerring
Copy link
Contributor Author

So.. it's not different because the change is already present somehow (bad merge?) My bad.

@lukebjerring lukebjerring deleted the rowsplit branch October 2, 2018 17:01
@lukebjerring lukebjerring restored the rowsplit branch October 2, 2018 17:02
@lukebjerring
Copy link
Contributor Author

.. I will tweak this here.

@lukebjerring lukebjerring reopened this Oct 2, 2018
foolip
foolip approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see it! LGTM, literally!

@lukebjerring lukebjerring merged commit 8b1ea2c into master Oct 2, 2018
@lukebjerring lukebjerring deleted the rowsplit branch October 2, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukebjerring @wpt-pr-bot @foolip