Remove the never-launched manifest frontend code #2469
Merged
+2
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the manifest in the frontend never shipped, and the flags are off in prod and staging. This code is non-trivial and removing it makes the code easier to understand. The /api/manifest endpoint is not removed because it is still used by Bikeshed[0]. [0]: https://github.com/tabatkins/bikeshed/blob/e797b9548c0bd140c9b1500809869b09f50f7d99/bikeshed/update/updateWpt.py Updates #56
|
Low priority and needs a careful look at it, but I think this is a nice cleanup of a chunk of code. |
KyleJu
reviewed
Mar 12, 2021
KyleJu
approved these changes
Mar 15, 2021
|
Note that /api/manifest is also used by GitHub checks in wpt-metadata |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the manifest in the frontend never shipped, and the flags are
off in prod and staging. This code is non-trivial and removing it makes
the code easier to understand.
The /api/manifest endpoint is not removed because it is still used by
Bikeshed
and the GitHub checks in wpt-metadata
Updates #56