Rename the "Verbose" toggle to "Expand" #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in expand/collapse details.
|
Staging instance deployed by Travis CI! |
|
Alternatively, we could call it "Compact" and change the default state. @mdittmer @Hexcles preferences? The reason "verbose" doesn't seem right to me is that apart from when you get to the testharness.js failure messages, the compact view doesn't omit any information, it's just more compact. If we do #422 (please?) I think "Compact" will make more sense in those views too. |
|
I prefer the compact view as a default but I'm not really a member of the target audience. |
|
I'm happy for that to be the default. The naming just changes whether the toggle is on or off by default. Between Compact, Expand and Verbose, do you have a preference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in expand/collapse details.