[EditContext] Don't populate getTargetRanges for deletions #42818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 28, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4985470
branch
from
7eb17f6 to
98f7b5d
Compare
In [1] the issue was raised that getTargetRanges() in beforeinput is not interoperable across browsers for deletions. We don't want to include non-interoperable behaviors in EditContext, so return an empty array for getTargetRanges() when beforeinput is received for deletions in EditContext. We may revisit this later on and start providing a range if interoperable behavior can be designed. [1] w3c/input-events#146 Bug: 999184 Change-Id: Iac697f89a7c7ecee57c850e7b929e42670c10e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985470 Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Reviewed-by: Anupam Snigdha <[email protected]> Cr-Commit-Position: refs/heads/main@{#1217018}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4985470
branch
from
98f7b5d to
eb4d5e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In [1] the issue was raised that getTargetRanges() in beforeinput
is not interoperable across browsers for deletions. We don't want to
include non-interoperable behaviors in EditContext, so return an empty
array for getTargetRanges() when beforeinput is received for deletions
in EditContext.
We may revisit this later on and start providing a range if
interoperable behavior can be designed.
[1] w3c/input-events#146
Bug: 999184
Change-Id: Iac697f89a7c7ecee57c850e7b929e42670c10e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4985470
Reviewed-by: Koji Ishii <[email protected]>
Commit-Queue: Dan Clark <[email protected]>
Reviewed-by: Anupam Snigdha <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1217018}