[Gecko Bug 1914322] Perform pending operations when the view transition is animating. #50403
+77
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, we have to schedule the performing pending operations after activating the view transitions, and stop to do that once we don't have active animations. There is one known issue: we always timeout even if we activate the view transitions successfully, so I clear the timeout once we start the animations. Otherwise, we may always interrupt the long animations whose durations are longer than `dom.viewTransitions.timeout-ms`. However, I guess we may still need a timeout for it. We probably need to figure out what to do in the future. Note that `/css/css-view-transitions/paused-animation-at-end.html.ini` is failed because we don't have any animations. This is probably blocked by the dynamic UA stylesheet (Bug 1914324). Also, update some other tests to avoid getting javascript errors: `JavaScript error: , line 0: uncaught exception: Object`. Differential Revision: https://phabricator.services.mozilla.com/D236215 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914322 gecko-commit: a8038a8d30ef9c16fcb65468ebc20ad363180ed6 gecko-reviewers: view-transitions-reviewers, emilio
wpt-pr-bot
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, we have to schedule the performing pending operations after
activating the view transitions, and stop to do that once we don't have
active animations.
There is one known issue: we always timeout even if we activate the view
transitions successfully, so I clear the timeout once we start the animations.
Otherwise, we may always interrupt the long animations whose
durations are longer than
dom.viewTransitions.timeout-ms. However, Iguess we may still need a timeout for it. We probably need to figure out
what to do in the future.
Note that
/css/css-view-transitions/paused-animation-at-end.html.iniis failed because we don't have any animations. This is probably blocked by
the dynamic UA stylesheet (Bug 1914324).
Also, update some other tests to avoid getting javascript errors:
JavaScript error: , line 0: uncaught exception: Object.Differential Revision: https://phabricator.services.mozilla.com/D236215
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1914322
gecko-commit: a8038a8d30ef9c16fcb65468ebc20ad363180ed6
gecko-reviewers: view-transitions-reviewers, emilio