Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: next #113

Merged
merged 1 commit into from
Oct 5, 2020
Merged

refactor: next #113

merged 1 commit into from
Oct 5, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Oct 5, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

  • drop@8 node
  • named export

Breaking Changes

Yes, above

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #113 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   97.57%   97.57%   -0.01%     
==========================================
  Files           6        6              
  Lines         702      700       -2     
  Branches      299      299              
==========================================
- Hits          685      683       -2     
  Misses         15       15              
  Partials        2        2              
Impacted Files Coverage Δ
src/ValidationError.js 96.69% <ø> (ø)
src/validate.js 100.00% <ø> (ø)
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102d170...c26bead. Read the comment docs.

@simonjoom
Copy link

simonjoom commented Jan 9, 2022

this refactor create an important issue for babel-loader which still didn't update their code according to

@alexander-akait
Copy link
Member Author

Can you clarify?

@simonjoom
Copy link

Can you clarify?

check here : babel/babel-loader#906 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants