-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install required packages for loading command automatically #2815
base: master
Are you sure you want to change the base?
Conversation
5b01260
to
ee4719f
Compare
smoke tests passing locally 😞. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, do you think it is better do for all commands? I think it will be good for init only, but I am fine with install all by default
Yes, we should do it for all. |
3eeadfb
to
5e0441c
Compare
5e0441c
to
cf9c840
Compare
0f42643
to
5732d24
Compare
5732d24
to
edac985
Compare
Codecov Report
@@ Coverage Diff @@
## master #2815 +/- ##
==========================================
- Coverage 95.01% 94.93% -0.09%
==========================================
Files 31 32 +1
Lines 1706 1717 +11
Branches 498 500 +2
==========================================
+ Hits 1621 1630 +9
- Misses 85 87 +2
Continue to review full report at Codecov.
|
/cc @webpack/cli-team, Can someone check it locally on |
@snitin315 Do we need this, I just checked and we don't ask about installation when I use |
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
WIP in tests
If relevant, did you update the documentation?
NA
Summary
#2809 (comment)
Does this PR introduce a breaking change?
No
Other information
No