-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(init-generator): add svelte template #2859
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
==========================================
- Coverage 95.01% 94.71% -0.30%
==========================================
Files 31 32 +1
Lines 1706 1723 +17
Branches 498 497 -1
==========================================
+ Hits 1621 1632 +11
- Misses 85 91 +6
Continue to review full report in Codecov by Sentry.
|
}, | ||
}, | ||
{ | ||
test: /\.css$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add support for postcss, sass, etc here. Like we have in default template. Maybe we can have some refactoring here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, ideally we should extend default template and add custom loaders/plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don’t need this. CWA (create webpack app) is going to be a standalone tool soon. Gsoc project.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
This PR aims at adding a
svelte
template forinit-generator
#2832Does this PR introduce a breaking change?
No
Other information
N/A