fixes #4178 #4179
Closed
fixes #4178 #4179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several internal module versions with deprecated warnings have been modernised. The associated 'unmet peer dependency' warning was also resolved by installing '@types/inquirer, @yeoman/types, mem-fs, webpack'.
The committers listed above are authorized under a signed CLA. |
|
Hi @stein2nd. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
snitin315
reviewed
Jun 3, 2024
| "version": "3.0.7", | ||
| "version": "3.0.8", |
There was a problem hiding this comment.
This should be updated only when the package is released.
snitin315
reviewed
Jun 3, 2024
Comment on lines
+33
to
+34
| "yeoman-environment": "^4.4.0", | ||
| "yeoman-generator": "^7.2.0" |
There was a problem hiding this comment.
There are no breaking changes?
There was a problem hiding this comment.
I'd read the changelogs from yeoman and maybe even the source. From experience, their version updates have a lot of changes that might break our implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several internal module versions with deprecated warnings have been modernised. The associated 'unmet peer dependency' warning was also resolved by installing '@types/inquirer, @yeoman/types, mem-fs, webpack'.
What kind of change does this PR introduce?
To resolve deprecated warnings.