Make BaseError#walk tolerant to an undefined cause
#2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alcuadrado is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 7e9d5b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alcuadrado
commented
Nov 1, 2024
| @@ -87,7 +87,7 @@ function walk( | |||
| fn?: ((err: unknown) => boolean) | undefined, | |||
| ): unknown { | |||
| if (fn?.(err)) return err | |||
| if (err && typeof err === 'object' && 'cause' in err) | |||
| if (err && typeof err === 'object' && 'cause' in err && err.cause !== undefined) | |||
There was a problem hiding this comment.
I'm pretty sure this doesn't pass the linter, but I had some installation issues. Sorry about that.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue where I was setting
Error.causetoundefined, andviemwas giving me some errors because it was trying to access anundefined. This PR fixes it.PR-Codex overview
This PR focuses on improving the
BaseError#walkmethod to handle cases where thecauseproperty isundefined, ensuring it doesn't throw errors in such scenarios.Detailed summary
BaseError#walkto check iferr.causeis notundefinedbefore recursively callingwalk.walkcorrectly handles an error with anundefinedcause.