Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of bs-highlighter and Prince XML. #277

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

jeremyroman
Copy link
Contributor

@jeremyroman jeremyroman commented Jun 15, 2023

Debian now complains about externally managed Python packages. bs-highlighter is now installed in its own little venv using pipx.

Prince's .deb (even for more recent releases) has not been updated for Debian 12, which is now stable, and is not installable. This switches to the tarball release, which has fewer shared library dependencies.

Debian now complains about externally managed Python packages.

This installs it into its own little virtual env.
The .deb package has not been updated for Debian 12, and depends on
shared libraries not available in Debian stable anymore. The tarball
version has fewer dynamic dependencies.
@jeremyroman jeremyroman changed the title Use pipx to install bs-highlighter. Fix installation of bs-highlighter and Prince XML. Jun 15, 2023
@jeremyroman jeremyroman marked this pull request as ready for review June 15, 2023 21:39
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for jumping on this!

@@ -16,7 +17,10 @@ RUN apt-get update && \
# - fonts, for when Prince renders to PDF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note here for the Prince dependencies. A shame we can't get them automatically through the deb anymore...

@domenic domenic merged commit 607b57c into whatwg:main Jun 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants