Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Perl preprocessing scripts #285

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Remove Perl preprocessing scripts #285

merged 2 commits into from
Oct 24, 2023

Conversation

domenic
Copy link
Member

@domenic domenic commented Oct 23, 2023

They were replaced by Rust versions in 188742d. Now that the --remote build is available, we should not keep these two code paths around.

Closes #234.


On top of #283 and should not be merged before that is.

Sadly perl is still needed for lint.sh.

Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running ./build.sh, I get this error:

./build.sh: line 648: CARGO_ARGS[@]: unbound variable

@sideshowbarker
Copy link
Contributor

I guess it needs to handle the case where ./build.sh is called with no arguments — specifically, without either the --verbose or --quiet arguments

@domenic
Copy link
Member Author

domenic commented Oct 23, 2023

Oh dear... cannot reproduce. Can you reproduce on main with PROCESS_WITH_RUST=true ./build.sh?

@sideshowbarker
Copy link
Contributor

Oh dear... cannot reproduce.

It might be a difference in bash versions. I have bash 5.2.15 in my environment

Can you reproduce on main with PROCESS_WITH_RUST=true ./build.sh?

Yup

build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

Base automatically changed from add-full-remote to main October 24, 2023 02:06
They were replaced by Rust versions in 188742d. Now that the --remote build is available, we should not keep these two code paths around.

Closes #234.
@domenic domenic merged commit 8edb2f6 into main Oct 24, 2023
1 check passed
@domenic domenic deleted the rm-perl-scripts branch October 24, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

.pre-process-main.pl can be simplified or rolled into Wattsi
2 participants