Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't duplicate descriptions arising from duplicate links in a single row in the attributes table. #289

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jeremyroman
Copy link
Contributor

@jeremyroman jeremyroman commented Oct 30, 2023

Various attributes (with IDs beginning like attr-dim-*, attr-dim-*, attr-fae-*, attr-fe-*, attr-media-*) have duplicate definition links (for various elements they apply to) which were being concatenated as though they were multiple distinct descriptions. These shouldn't be duplicated (these descriptions are by definition identical).

Fixes whatwg/html#9889.

@jeremyroman
Copy link
Contributor Author

@domenic ptal?

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rapid response!

@domenic domenic merged commit 0334e03 into whatwg:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Description of the width/height attributes are just a repeated string over and over again
2 participants