Make togglePopover return a boolean #9393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes togglePopover return true if it opens the popover or false if it closes it. Fixes whatwg#9043
|
Looks good, may be worth fixing #8999 as well. |
annevk
reviewed
Jun 7, 2023
source
Outdated
| @@ -82665,10 +82666,14 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> { | |||
| <li><p>If <span>this</span>'s <span>popover visibility state</span> is <span | |||
| data-x="popover-showing-state">showing</span>, and <var>force</var> is not present or false, then | |||
| run the <span>hide popover algorithm</span> given <span>this</span>, true, true, and | |||
| true.</p></li> | |||
| true, then return false.</p></li> | |||
There was a problem hiding this comment.
Can we not end up in a situation where hide returns early without changing the state? E.g., if hide all popovers made some changes.
I think we have to return something at the end based on the current state, instead. This might need test coverage too as @rwlbuis's WebKit implementation didn't catch this. (Assuming I'm correct.)
There was a problem hiding this comment.
Ok, I made it return whether the popover is actually open instead of just returning true or false or force, and I updated the WPT
annevk
reviewed
Jun 8, 2023
annevk
approved these changes
Jun 8, 2023
webkit-commit-queue
pushed a commit
to rwlbuis/WebKit
that referenced
this pull request
Jun 12, 2023
https://bugs.webkit.org/show_bug.cgi?id=257769 Reviewed by Tim Nguyen. Implement togglePopover API change: whatwg/html#9393 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover.html: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::togglePopover): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLElement.idl: Canonical link: https://commits.webkit.org/265064@main
|
@josepharhar would you be willing to update OP and address the nit? No need for a WebKit bug. |
Done |
mnutt
pushed a commit
to movableink/webkit
that referenced
this pull request
Jun 28, 2023
https://bugs.webkit.org/show_bug.cgi?id=257769 Reviewed by Tim Nguyen. Implement togglePopover API change: whatwg/html#9393 * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/togglePopover.html: Added. * Source/WebCore/html/HTMLElement.cpp: (WebCore::HTMLElement::togglePopover): * Source/WebCore/html/HTMLElement.h: * Source/WebCore/html/HTMLElement.idl: Canonical link: https://commits.webkit.org/265064@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes togglePopover return true if it opens the popover or false if it closes it.
Fixes #9043
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/popover.html ( diff )