Editorial: remove plugin language from media elements #9440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
commented
Jun 19, 2023
| @@ -34454,7 +34454,7 @@ interface <dfn interface>HTMLVideoElement</dfn> : <span>HTMLMediaElement</span> | |||
|
|
|||
| <!- - similar note in audio codecs section - -> | |||
| <p class="note">Implementations are free to implement support for video codecs either natively, or | |||
| using platform-specific APIs, or using plugins: this specification does not specify how codecs are | |||
| using platform-specific APIs: this specification does not specify how codecs are | |||
There was a problem hiding this comment.
Note that this is cleaning up the contents of a comment. As such I didn't feel the need to rewrap since we'd probably change it anyway if we ever decided to add this language. (Same below.)
domenic
approved these changes
Jun 20, 2023
| const videoSection = document.getElementById('video'); | ||
| const videoElement = document.createElement('video'); | ||
| const support = videoElement.canPlayType('video/x-new-fictional-format;codecs="kittens,bunnies"'); | ||
| if (support === "probably") { | ||
| while (videoSection.hasChildNodes()) |
There was a problem hiding this comment.
Feel free to replace the contents of this if block with videoSection.replaceChildren(videoElement) (plus the src-setting line).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/media.html ( diff )