Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new login use case chooser for context enterprise vs fallback (WPB-15966) #3287

Draft
wants to merge 5 commits into
base: epic/new-sso-login-flow
Choose a base branch
from

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 7, 2025

TaskWPB-15966 [Android] Create use case to select old vs new login flow


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Creates use case to fetch and observe the LoginContext (Enterprise or Fallback) according to conditions
    • Api version negotiated
    • Proxy authenticated or not
    • Possible errors in these scenarios
  • Create extension of Server config repository, removing duplication and extended.

Testing

NOT for now, I will add when leaving draft state.

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Feb 7, 2025

@yamilmedina yamilmedina requested a review from saleniuk February 7, 2025 15:47
@yamilmedina yamilmedina changed the title feat: enterprise login create use case to decide which Context to use or fallback (WPB-15966) feat: new login use case chooser for context enterprise vs fallback (WPB-15966) Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Results

825 tests   813 ✅  5m 3s ⏱️
  7 suites   12 💤
  7 files      0 ❌

Results for commit a540005.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/new-login-oldnewversion-usecase
Commit report: c6fb5ea
Test service: kalium-jvm

✅ 0 Failed, 803 Passed, 40 Skipped, 59.56s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant