-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New user properties for Analytics [WPB-16121] #3312
base: develop
Are you sure you want to change the base?
Conversation
Test Results2 991 tests - 538 2 981 ✅ - 438 4m 43s ⏱️ - 1m 53s Results for commit 7c36450. ± Comparison against base commit 678cab5. This pull request removes 3529 and adds 2991 tests. Note that renamed tests count towards both.
This pull request removes 110 skipped tests and adds 10 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
|
Branch | feat/new_user_properties_for_analytics |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
flag.
Click to view all benchmark results
Benchmark | Latency | microseconds (µs) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 745.50 µs |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 325,126.91 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,365,520.03 µs |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 27,894.61 µs |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3312 +/- ##
===========================================
+ Coverage 50.72% 50.76% +0.03%
===========================================
Files 1610 1612 +2
Lines 58206 58317 +111
Branches 5255 5272 +17
===========================================
+ Hits 29525 29603 +78
- Misses 26649 26670 +21
- Partials 2032 2044 +12 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 1 Passed, 0 Skipped, 0s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only one question about where to add the new functions
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/user/UserRepository.kt
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Users.sq
Outdated
Show resolved
Hide resolved
...commonMain/kotlin/com/wire/kalium/logic/feature/analytics/GetAnalyticsContactsDataUseCase.kt
Show resolved
Hide resolved
|
What's new in this PR?
Need to implement new user properties 2 of them: amount of users contacts AND amount of team member in users team.
Solutions
MetaDataDao
. That caches should refresh after 7 days.GetAnalyticsContactsDataUseCase
for getting cached values and combining all the necessary data intoAnalyticsContactsData
data classUpdateContactsAmountsCacheUseCase
for refreshing the cache and run it inUserSessionScope