Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Server): express import warnings #18306

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Nov 14, 2024

Description

I've found the warnings for each PR annoying, so I've decided to turn them off :)

Screenshot 2024-11-14 at 08 26 48

Checklist

  • mentions the JIRA issue in the PR name (Ex. WPB-423)
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

sonarcloud bot commented Nov 14, 2024

Copy link
Contributor

@e-maad e-maad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@olafsulich olafsulich changed the title refactor(Server): streamline static route handling in server initialization fix(Server): express import warnings Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.60%. Comparing base (bc7fd5d) to head (dfd553b).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18306   +/-   ##
=======================================
  Coverage   46.60%   46.60%           
=======================================
  Files         828      828           
  Lines       26017    26017           
  Branches     5894     5894           
=======================================
  Hits        12124    12124           
  Misses      12380    12380           
  Partials     1513     1513           

@olafsulich olafsulich merged commit ff72801 into dev Nov 14, 2024
20 checks passed
@olafsulich olafsulich deleted the fix/express-import-warnings branch November 14, 2024 07:33
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: refactoring 🛠
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants