feat: Clickable read receipt on Ping Message #18308
Merged
+56
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18308 +/- ##
==========================================
- Coverage 46.61% 46.57% -0.05%
==========================================
Files 828 828
Lines 26017 26028 +11
Branches 5894 5898 +4
==========================================
- Hits 12128 12122 -6
- Misses 12377 12391 +14
- Partials 1512 1515 +3 |
olafsulich
reviewed
Nov 14, 2024
| message, | ||
| ['unsafeSenderName', 'caption', 'ephemeral_caption', 'isObfuscated', 'get_icon_classes'], | ||
| ); | ||
| const PingMessage = ({message, is1to1Conversation, isLastDeliveredMessage, onClickDetails}: PingMessageProps) => { |
There was a problem hiding this comment.
I've started it on localhost and this is what I see. It's not supposed to be like that, is it?
There was a problem hiding this comment.
good catch, is this only in 1 on 1?
There was a problem hiding this comment.
Whoops.. let me check it
|
echoes-hq
bot
added
the
echoes: product-roadmap/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now it's possible to click on read receipt on Ping Message.
Checklist