fix: adjust background color for in call reactions tooltip [WPB-14328] #18310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
V-Gira
commented
Nov 14, 2024
| @@ -167,7 +167,7 @@ | |||
| border-radius: 1rem; | |||
| font-size: 1.5rem; | |||
| &:hover { | |||
| background-color: var(--inactive-call-button-border); | |||
| background-color: var(--inactive-call-button-hover-bg); | |||
There was a problem hiding this comment.
more inline with the rest of the call ui button it does change the light mode hover state (couldn't find hover states on figma)
Before:
After:
V-Gira
commented
Nov 14, 2024
| @@ -142,7 +142,7 @@ | |||
| display: grid; | |||
| padding: 0.4rem; | |||
| border-radius: 1rem; | |||
| background-color: #fff; | |||
| background-color: var(--app-bg-secondary); | |||
There was a problem hiding this comment.
var(--app-bg-secondary) seems to fit here, white in light mode, black in dark mode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #18310 +/- ##
=======================================
Coverage 46.58% 46.58%
=======================================
Files 828 828
Lines 26029 26030 +1
Branches 5898 5899 +1
=======================================
+ Hits 12125 12127 +2
Misses 12390 12390
+ Partials 1514 1513 -1 |
dariaoldenburg
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
assign css variable for tooltip's background compatible with dark mode
Screenshots/Screencast (for UI changes)
Before:
After:
Checklist