Draft: feat: Support Sample Responses #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
tomharmon
force-pushed
the
feat/sample-responses
branch
from
cf01b42 to
f3eea61
Compare
tomharmon
force-pushed
the
feat/sample-responses
branch
from
f3eea61 to
f6a4297
Compare
|
I'll be adding some comments here mainly to just discuss about things, feel free to point out anything you want aswell. |
wllfaria
reviewed
Aug 18, 2024
| @@ -60,16 +61,18 @@ impl PaneFocus { | |||
| PaneFocus::Sidebar => PaneFocus::ReqUri, | |||
| PaneFocus::ReqUri => PaneFocus::Editor, | |||
| PaneFocus::Editor => PaneFocus::Preview, | |||
| PaneFocus::Preview => PaneFocus::Sidebar, | |||
| PaneFocus::Preview => PaneFocus::SampleResponse, | |||
| PaneFocus::SampleResponse => PaneFocus::Sidebar, | |||
There was a problem hiding this comment.
personally, I think Sample responses may be best suited to live within Pretty/Raw response viewers, i'm not sure how we should allow the user to switch between actual current response and saved sample responses, but I think a whole new pane for this is not really needed, what you think?
wllfaria
reviewed
Aug 18, 2024
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub body: Option<String>, | ||
| #[serde(skip_serializing_if = "IndexMap::is_empty")] | ||
| pub headers: IndexMap<String, Vec<String>>, |
There was a problem hiding this comment.
I assume here the idea behind the IndexMap is to preserve order of headers on serialization? I asked this question with the headers for requests, I'm still not sure if this is a huge deal, but I guess its fine
wllfaria
force-pushed
the
main
branch
2 times, most recently
from
07bacb0 to
92413dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #16 for background and motivation
Solution
PaneFocus::SampleResponsevariant and aVec<SampleResponse>to a request.