Quoted the path for the Task, so that install paths with spaces work …

…too.
wokhan · May 20, 2017 · fcda27f · fcda27f
1 parent a3ea6d2
commit fcda27f
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/Console/Helpers/InstallHelper.cs b/Console/Helpers/InstallHelper.cs
@@ -150,14 +150,15 @@ private static bool CreateDefaultRules()
         private static bool createTask(bool allUsers)
         {
             string tmpXML = Path.GetTempFileName();
-            var taskStr = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream("Wokhan.WindowsFirewallNotifier.Console.Resources.TaskTemplate.xml"));
-            var newtask = String.Format(taskStr.ReadToEnd(),
-                                        allUsers ? "<UserId>NT AUTHORITY\\SYSTEM</UserId>"//"<GroupId>S-1-5-32-545</GroupId>" 
-                                                 : "<UserId><![CDATA[" + WindowsIdentity.GetCurrent().Name + "]]></UserId>",
-                                        Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Notifier.exe"),
-                                        DateTime.Now.ToString("s"));
-
-            taskStr.Close();
+            string newtask;
+            using (var taskStr = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream("Wokhan.WindowsFirewallNotifier.Console.Resources.TaskTemplate.xml")))
+            {
+                 newtask = String.Format(taskStr.ReadToEnd(),
+                                         allUsers ? "<UserId>NT AUTHORITY\\SYSTEM</UserId>"//"<GroupId>S-1-5-32-545</GroupId>" 
+                                                  : "<UserId><![CDATA[" + WindowsIdentity.GetCurrent().Name + "]]></UserId>",
+                                         "\"" + Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Notifier.exe") + "\"",
+                                         DateTime.Now.ToString("s"));
+            }
 
             File.WriteAllText(tmpXML, newtask, Encoding.Unicode);