Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dual alg: add ML-DSA test, and misc cleanup. #8425

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Feb 6, 2025

Description

Add a dual-alg ML-DSA + ECDSA test, and some miscellaneous cleanup:

  • Add test_dual_alg_ecdsa_mldsa() to tests/api.c (Based on ecdsa + mldsa demo here: https://github.com/wolfSSL/wolfssl-examples/tree/master/X9.146).
  • Add missing comments to ASN functions, and trim line lengths.
  • Remove unused WOLFSSL_LOCAL function wc_ConfirmAltSignature().
  • Add missing wc_MlDsaKey_*KeyToDer() define to wolfssl/wolfcrypt/dilithium.h

Testing

./configure --enable-experimental --enable-dual-alg-certs --enable-dilithium --enable-debug && make
./tests/unit.test --list | grep dual_alg
338: test_dual_alg_support
339: test_dual_alg_ecdsa_mldsa
./tests/unit.test -339

@philljj philljj self-assigned this Feb 6, 2025
@philljj
Copy link
Contributor Author

philljj commented Feb 7, 2025

retest this please

@philljj philljj requested a review from anhu February 7, 2025 17:14
@philljj philljj assigned anhu and wolfSSL-Bot and unassigned philljj Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants