Read DER BIO: fix for when BIO data is less than seq buffer size #8426
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
read_der_bio_small_data_fix
branch
from
ab785f7 to
dd4bd4d
Compare
wolfssl_read_der_bio did not not handle the length to be read from the BIO being less than the size of the sequence buffer.
SparkiDev
force-pushed
the
read_der_bio_small_data_fix
branch
from
dd4bd4d to
ae8b8c4
Compare
|
retest this please Hudson failure |
dgarske
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wolfssl_read_der_bio did not not handle the length to be read from the BIO being less than the size of the sequence buffer.
Fixes zd#19363
Testing
./configure '--disable-shared' '--enable-opensslall' '--enable-keygen' 'CC=clang -fsanitize=address'
make
./tests/unit.test -test_wolfSSL_d2i_PrivateKeys_bio
Checklist