ML-KEM/Kyber: improvements

[SparkiDev]

Description

ML-KEM/Kyber:
MakeKey call generate random once only for all data.
Allow MakeKey/Encapsulate/Decapsulate to be compiled separately.
Pull out public key decoding common to public and private key decode.
Put references to FIPS 140-3 into code. Rename variables to match FIPS 140-3.
Fix InvNTT assembly code for x64 - more reductions.
Split out ML-KEM/Kyber tests from api.c.

TLSX:
Store the object instead of the private key when WOLFSSL_MLKEM_CACHE_A is defined or WOLFSSL_TLSX_PQC_MLKEM_STORE_OBJ. Faster decapsulation when A is cached and object stored.
To store private key as normal define
WOLFSSL_TLSX_PQC_MLKEM_STORE_PRIV_KEY.

misc.c: when Intel x64 build, assume able to read/write unaligned

Testing

Regression tested ML-KEM/Kyber

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[JacobBarthelmeh]

./configure CC="clang-15 -fsanitize=address" --enable-kyber=make

  CC       examples/benchmark/tls_bench.o
src/tls.c:7998:39: error: unused parameter 'type' [-Werror,-Wunused-parameter]
static int kyber_id2type(int id, int *type)
                                      ^
1 error generated.

Similar warning with ./configure CC="clang-15 -fsanitize=address" --enable-kyber=enc

./configure CC="clang-15 -fsanitize=address" --enable-kyber=dec

wolfcrypt/src/wc_kyber.c:1207:30: error: variable 'compVecSz' is uninitialized when used here [-Werror,-Wuninitialized]
        const byte* c2 = c + compVecSz;
                             ^~~~~~~~~
wolfcrypt/src/wc_kyber.c:1138:27: note: initialize the variable 'compVecSz' to silence this warning
    unsigned int compVecSz;
                          ^
                           = 0
1 error generated.
make[2]: *** [Makefile:8200: wolfcrypt/src/src_libwolfssl_la-wc_kyber.lo] Error 1

`

[SparkiDev]

./configure CC="clang-15 -fsanitize=address" --enable-kyber=make

  CC       examples/benchmark/tls_bench.o
src/tls.c:7998:39: error: unused parameter 'type' [-Werror,-Wunused-parameter]
static int kyber_id2type(int id, int *type)
                                      ^
1 error generated.

Similar warning with ./configure CC="clang-15 -fsanitize=address" --enable-kyber=enc

./configure CC="clang-15 -fsanitize=address" --enable-kyber=dec

wolfcrypt/src/wc_kyber.c:1207:30: error: variable 'compVecSz' is uninitialized when used here [-Werror,-Wuninitialized]
        const byte* c2 = c + compVecSz;
                             ^~~~~~~~~
wolfcrypt/src/wc_kyber.c:1138:27: note: initialize the variable 'compVecSz' to silence this warning
    unsigned int compVecSz;
                          ^
                           = 0
1 error generated.
make[2]: *** [Makefile:8200: wolfcrypt/src/src_libwolfssl_la-wc_kyber.lo] Error 1

`

Need to specify --enable-kyber=512,768,1024,enc

Changed the header files to detect whether a key length has been specified.
Also whether an operation has been specified.

[dgarske]

Retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:"